Scope of method and property

Coordinator
Oct 6, 2011 at 10:12 PM

Now, following method and property are public.

  • CollectionExtensions.SetHashCode
  • CollectionExtensions.SetEquals
  • ArrayComparer<T>
  • SelectComparer<T>
  • ColumnExtensions.ColumnComparerByName
  • CounterColumnExtensions.CounterColumnComparerByName

These member is useful. User gain profit from them.

But we must support public member in the future.

Which member should stay public? And, which member should make internal?

What do you think?

Developer
Oct 8, 2011 at 9:58 AM

Hmm. I'm okay with them either being public or internal.

They're not directly related with Cassandraemon. On the other hand, they're so basic that I do not foresee breaking change possibilities.

Can you make the call?

Note that I just noticed "SetHashCode" is a bad naming; it "gets" a hash code for a "set", but it sounds like it "sets" hash code. I'm going to change the name.

Coordinator
Oct 8, 2011 at 12:16 PM

Keeping simple is the best way. My guess is that all of above methods and class should be internal.

I make work item. Click this to move issue page.